netdev - Re: [PATCH net 2/2] selftests: forwarding: Remove executable bits from lib.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad0a8b8b04a6c767942cf0d89e8048c349175995.camel@redhat.com>
Date: Tue, 16 Jan 2024 09:32:04 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Benjamin Poirier <bpoirier@...dia.com>, netdev@...r.kernel.org
Cc: Jay Vosburgh <j.vosburgh@...il.com>, Andy Gospodarek
 <andy@...yhouse.net>,  Shuah Khan <shuah@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,  Jakub Kicinski
 <kuba@...nel.org>, Petr Machata <petrm@...dia.com>, Nikolay Aleksandrov
 <razor@...ckwall.org>, Hangbin Liu <liuhangbin@...il.com>, Ido Schimmel
 <idosch@...dia.com>, Vladimir Oltean <vladimir.oltean@....com>, Jonathan
 Toppins <jon.toppins+linux@...il.com>, Joachim Wiberg
 <troglobit@...il.com>,  linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 2/2] selftests: forwarding: Remove executable bits
 from lib.sh

On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote:
> The lib.sh script is meant to be sourced from other scripts, not executed
> directly. Therefore, remove the executable bits from lib.sh's permissions.

LGTM, but there is any special reason to not fix the permissions of
other *lib.sh files in the same directory? Could be a follow-up.

Thanks!

Paolo