[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51e73530-7c65-4e2f-9749-7dbbe9098fde@ieee.org>
Date: Tue, 16 Jan 2024 05:44:48 -0600
From: Alex Elder <elder@...e.org>
To: Colin Ian King <colin.i.king@...il.com>, Alex Elder <elder@...nel.org>,
"David S . Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net: ipa: remove the redundant assignment to
variable trans_id
On 1/16/24 5:40 AM, Colin Ian King wrote:
> The variable trans_id is being modulo'd by channel->tre_count and
> the value is being re-assigned back to trans_id even though the
> variable is not used after this operation. The assignment is
> redundant. Remove the assignment and just replace it with the modulo
> operator.
>
> Cleans up clang scan build warning:
> warning: Although the value stored to 'trans_id' is used in the
> enclosing expression, the value is never actually read from
> 'trans_id' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
This looks good. I saw this before but hadn't gotten around to
fixing it yet. Thank you!
Reviewed-by: Alex Elder <elder@...aro.org>
> ---
> drivers/net/ipa/gsi_trans.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c
> index ee6fb00b71eb..f5dafc2f53ab 100644
> --- a/drivers/net/ipa/gsi_trans.c
> +++ b/drivers/net/ipa/gsi_trans.c
> @@ -247,7 +247,7 @@ struct gsi_trans *gsi_channel_trans_complete(struct gsi_channel *channel)
> return NULL;
> }
>
> - return &trans_info->trans[trans_id %= channel->tre_count];
> + return &trans_info->trans[trans_id % channel->tre_count];
> }
>
> /* Move a transaction from allocated to committed state */
Powered by blists - more mailing lists