netdev - Re: [RFC iproute2 v5 1/3] ss: add support for BPF socket-local storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13b5ab0a-e906-485d-a803-8f6150f8694c@linux.dev>
Date: Wed, 17 Jan 2024 10:49:27 -0800
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Quentin Deslandes <qde@...cy.de>
Cc: David Ahern <dsahern@...il.com>, Martin KaFai Lau
 <martin.lau@...nel.org>, kernel-team@...a.com, netdev@...r.kernel.org
Subject: Re: [RFC iproute2 v5 1/3] ss: add support for BPF socket-local
 storage

On 1/15/24 8:46 AM, Quentin Deslandes wrote:
> +static struct rtattr *bpf_map_opts_alloc_rta(void)
> +{
> +	struct rtattr *stgs_rta, *fd_rta;
> +	size_t total_size;
> +	unsigned int i;
> +	void *buf;
> +
> +	/* If bpf_map_opts.show_all == true, we will send an empty message to
> +	 * the kernel, which will return all the socket-local data attached to
> +	 * a socket, no matter their map ID. */
> +	if (bpf_map_opts.show_all) {
> +		total_size = RTA_LENGTH(0);

This addressed the issue I saw in v4. Thanks!

The set is already very useful in the current form. Thanks for working on it.

> +	} else {
> +		total_size = RTA_LENGTH(RTA_LENGTH(sizeof(int)) *
> +					bpf_map_opts.nr_maps);
> +	}