netdev - Re: [PATCH net] xfrm: Clear low order bits of ->flowi4_tos in decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZaeAGc4AORHQuBGM@gauss3.secunet.de>
Date: Wed, 17 Jan 2024 08:22:01 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Guillaume Nault <gnault@...hat.com>
CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, Florian Westphal <fw@...len.de>, Simon Horman
	<horms@...nel.org>, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net] xfrm: Clear low order bits of ->flowi4_tos in
 decode_session4().

On Wed, Jan 03, 2024 at 04:06:32PM +0100, Guillaume Nault wrote:
> Commit 23e7b1bfed61 ("xfrm: Don't accidentally set RTO_ONLINK in
> decode_session4()") fixed a problem where decode_session4() could
> erroneously set the RTO_ONLINK flag for IPv4 route lookups. This
> problem was reintroduced when decode_session4() was modified to
> use the flow dissector.
> 
> Fix this by clearing again the two low order bits of ->flowi4_tos.
> Found by code inspection, compile tested only.
> 
> Fixes: 7a0207094f1b ("xfrm: policy: replace session decode with flow dissector")
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

Applied, thanks a lot!