netdev - Re: [PATCH v22 08/20] nvme-tcp: Deal with netdevice DOWN events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <253jzo8uvfl.fsf@nvidia.com>
Date: Wed, 17 Jan 2024 12:05:18 +0200
From: Aurelien Aptel <aaptel@...dia.com>
To: Sagi Grimberg <sagi@...mberg.me>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, hch@....de, kbusch@...nel.org, axboe@...com,
 chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org
Cc: Or Gerlitz <ogerlitz@...dia.com>, aurelien.aptel@...il.com,
 smalin@...dia.com, malin1024@...il.com, yorayz@...dia.com,
 borisp@...dia.com, galshalom@...dia.com, mgurtovoy@...dia.com
Subject: Re: [PATCH v22 08/20] nvme-tcp: Deal with netdevice DOWN events

Sagi Grimberg <sagi@...mberg.me> writes:
>
> Will this handler ever react to another type of event? because
> if not, maybe its better to just have:
>
>         if (event != NETDEV_GOING_DOWN)
>                 return NOTIFY_DONE;
>
>         ...

Hi Sagi,

This patch was already reviewed-by you. If you wish we can change the
switch to an if. Any other comments on other patches?

Thanks