[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZafLhL9U3f/i07BU@calendula>
Date: Wed, 17 Jan 2024 13:43:48 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Pavel Tikhomirov <ptikhomirov@...tuozzo.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Florian Westphal <fw@...len.de>, David Ahern <dsahern@...nel.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
Kees Cook <keescook@...omium.org>,
Nikolay Aleksandrov <razor@...ckwall.org>,
Roopa Prabhu <roopa@...dia.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
coreteam@...filter.org, bridge@...ts.linux.dev, kernel@...nvz.org
Subject: Re: [PATCH v3 0/4] netlink: bridge: fix nf_bridge->physindev use
after free
On Thu, Jan 11, 2024 at 11:06:36PM +0800, Pavel Tikhomirov wrote:
> Code processing skb from neigh->arp_queue can access its
> nf_bridge->physindev, which can already be freed, leading to crash.
>
> So, as Florian suggests, we can put physinif on nf_bridge and peek into
> the original device with dev_get_by_index_rcu(), so that we can be sure
> that device is not freed under us.
>
> This is a second attempt to fix this issue, first attempt:
>
> "neighbour: purge nf_bridged skb from foreign device neigh"
> https://lore.kernel.org/netdev/20240108085232.95437-1-ptikhomirov@virtuozzo.com/
I have applied this series to nf.git
I have added a Fixed: tag sufficiently old to the patch fix so it can
reach -stable at some point.
My understanding is that this problem has been always there for
br_netfilter.
Powered by blists - more mailing lists