netdev - Re: [PATCH v5 iwl-next 5/6] ice: factor out ice_ptp_rebuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB5800A07A871D0EF78AA87DBA86712@MW4PR11MB5800.namprd11.prod.outlook.com>
Date: Thu, 18 Jan 2024 17:36:03 +0000
From: "Kolacinski, Karol" <karol.kolacinski@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>
Subject: Re: [PATCH v5 iwl-next 5/6] ice: factor out ice_ptp_rebuild_owner()

On Mon, Jan 15, 2024 at 11:39AM +0100, Simon Horman wrote:
> > @@ -2729,11 +2718,41 @@ void ice_ptp_reset(struct ice_pf *pf, enum ice_reset_req reset_type)
> >        if (!ice_is_e810(hw)) {
> >                /* Enable quad interrupts */
> >                err = ice_ptp_cfg_phy_interrupt(pf, true, 1);
> > +             if (err)
> > +                     return err;
> > +
> > +             ice_ptp_restart_all_phy(pf);
> 
> The conditions for calling ice_ptp_restart_all_phy() seem to have
> changed (though perhaps in practice they are the same).
> And the ordering of this operation relative to the following code has
> changed:
> 
>         /* Init Tx structures */
>         if (ice_is_e810(&pf->hw)) {
>                 err = ice_ptp_init_tx_e810(pf, &ptp->port.tx);
>         } else {
>                 kthread_init_delayed_work(&ptp->port.ov_work,
>                                           ice_ptp_wait_for_offsets);
>                 err = ice_ptp_init_tx_e82x(pf, &ptp->port.tx,
>                                            ptp->port.port_num);
>         }
> 
>         ptp->state = ICE_PTP_READY;
> 
> Is this intentional?
> 
> I do see that the above code is removed in the following patch,
> and replaced by a call to ice_ptp_flush_all_tx_tracker()
> in ice_ptp_rebuild_owner(). But perhaps this patch
> should move this code block code to that location?

ice_ptp_restart_all_phy() was previously done for clock owner on
non-PF reset. This patch adds only a check if the device is not E810,
because only E82X devices need PHY restart.

ice_ptp_init_tx_<dev> location does not matter as long as it's done
before setting ICE_PTP_READY.

Thanks,
Karol