netdev - Re: [PATCH net] ipv6: mcast: fix data-race in ipv6_mc_down / mld_ifc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zaj1nZRBkWaDfo-e@Laptop-X1>
Date: Thu, 18 Jan 2024 17:55:41 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Taehee Yoo <ap420073@...il.com>
Cc: Nikita Zhandarovich <n.zhandarovich@...tech.ru>,
	"David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	syzbot+a9400cabb1d784e49abf@...kaller.appspotmail.com
Subject: Re: [PATCH net] ipv6: mcast: fix data-race in ipv6_mc_down /
 mld_ifc_work

On Thu, Jan 18, 2024 at 04:24:52PM +0900, Taehee Yoo wrote:
> > I saw mld_process_v1() also cancel these works when changing to v1 mode.
> > Should we also add lock there?
> 
> I think mld_process_v1() doesn't have a problem.
> Because mld_process_v1() is always called under mc_lock by mld_query_work().
> 
> mld_query_work()
>    mutex_lock(&idev->mc_lock);
>     __mld_query_work();
>        mld_process_v1();
>    mutex_unlock(&idev->mc_lock);

Thanks for this info, then this works for me.

Hangbin