netdev - Re: [PATCH net 2/2] selftests: forwarding: Remove executable bits from lib.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZarwDNeEgeJ529sW@d3>
Date: Fri, 19 Jan 2024 16:56:28 -0500
From: Benjamin Poirier <bpoirier@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>, Shuah Khan <shuah@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Petr Machata <petrm@...dia.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Hangbin Liu <liuhangbin@...il.com>,
	Ido Schimmel <idosch@...dia.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Jonathan Toppins <jon.toppins+linux@...il.com>,
	Joachim Wiberg <troglobit@...il.com>,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 2/2] selftests: forwarding: Remove executable bits
 from lib.sh

On 2024-01-16 09:32 +0100, Paolo Abeni wrote:
> On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote:
> > The lib.sh script is meant to be sourced from other scripts, not executed
> > directly. Therefore, remove the executable bits from lib.sh's permissions.
> 
> LGTM, but there is any special reason to not fix the permissions of
> other *lib.sh files in the same directory? Could be a follow-up.

I just looked into it and as of dbc153fd3c14 other *lib.sh files under
tools/testing/selftests/net/forwarding/ do not have any executable bits.
Did I miss something?

tools/testing/selftests/net/setup_loopback.sh has an unneccessary +x,
I'll send a patch for that one.