[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zazj5KI7BZPnLoc2@hog>
Date: Sun, 21 Jan 2024 10:29:08 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc: netdev@...r.kernel.org, Gal Pressman <gal@...dia.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>,
Radu Pirea <radu-nicolae.pirea@....nxp.com>,
"David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net v2 2/2] net: macsec: Only require headroom/tailroom
from offload implementer if .mdo_insert_tx_tag is implemented
2024-01-18, 11:18:07 -0800, Rahul Rameshbabu wrote:
> A number of MACsec offload implementers do not implement
> .mdo_insert_tx_tag. These implementers also do not specify the needed
> headroom/tailroom and depend on the default in the core MACsec stack.
FWIW, I had the same concern when Radu submitted these changes, and he
answered that the extra room was only needed for SW, not for offload:
https://lore.kernel.org/all/a5ef22bc-2457-5eef-7cff-529711c5c242@oss.nxp.com/
I'm not really objecting to this patch, but is it fixing a bug? If so,
it would be useful to describe the problem you're seeing in the commit
message for this change.
Does your driver require the default headroom/tailroom?
> Fixes: a73d8779d61a ("net: macsec: introduce mdo_insert_tx_tag")
> Cc: Radu Pirea (NXP OSS) <radu-nicolae.pirea@....nxp.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Sabrina Dubroca <sd@...asysnail.net>
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
--
Sabrina
Powered by blists - more mailing lists