netdev - Re: [PATCH net v2] selftests: net: fix rps_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240121203738.GE110624@kernel.org>
Date: Sun, 21 Jan 2024 20:37:38 +0000
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, shuah@...nel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net v2] selftests: net: fix rps_default_mask with >32 CPUs

On Sun, Jan 21, 2024 at 08:34:38PM +0000, Simon Horman wrote:
> On Sat, Jan 20, 2024 at 01:02:56PM -0800, Jakub Kicinski wrote:
> > If there is more than 32 cpus the bitmask will start to contain
> > commas, leading to:
> > 
> > ./rps_default_mask.sh: line 36: [: 00000000,00000000: integer expression expected
> > 
> > Remove the commas, bash doesn't interpret leading zeroes as oct
> > so that should be good enough.
> > 
> > Fixes: c12e0d5f267d ("self-tests: introduce self-tests for RPS default mask")
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > ---
> > v2:
> >  - remove all commas
> > v1: https://lore.kernel.org/all/20240119151248.3476897-1-kuba@kernel.org/
> 
> Thanks,
> 
> this version looks good to me.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Sorry, I may have been a bit hasty there.

When using bash the change seems to work just fine.

But when exercising this with dash I get:

sh: 10: Bad substitution