[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b84df52a-f144-4ec3-b81b-20d1a0176aff@lunn.ch>
Date: Mon, 22 Jan 2024 18:34:12 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ziyang Huang <hzyitc@...look.com>
Cc: mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
richardcochran@...il.com, p.zabel@...gutronix.de,
matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
linux-mediatek@...ts.infradead.org,
Praveenkumar I <ipkumar@...eaurora.org>,
Abhishek Sahu <absahu@...eaurora.org>
Subject: Re: [PATCH 5/8] clk: qcom: support for duplicate freq in RCG2 freq
table
> > > Change-Id: I97d9e1b55d8f3ee095f6f01729af527ba90e50e5
> > > Signed-off-by: Abhishek Sahu <absahu@...eaurora.org>
> > > (cherry picked from commit 775e7d3b69ffc97afb5bd5a6c9c423f2f4d8a0b2)
> > > Signed-off-by: Praveenkumar I <ipkumar@...eaurora.org>
> > >
> > > Change-Id: If10193fc79a3c1375ab73597813745ff1f4df0ad
> > >
> > > Pick from https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/commit/6dfb368bae130bee58e00ddf8330b55066e1c8c5
> > >
> > > Signed-off-by: Ziyang Huang <hzyitc@...look.com>
> >
> > Please clean up these tags. These Change-ID tags are meaningless in
> > mainline. 775e7d3b69ffc97afb5bd5a6c9c423f2f4d8a0b2 is not in mainline
> > either. The picked from might be interesting, but please put it into
> > the body of the commit message, not mixed in with the tags.
> >
> > Who actually wrote this patch? The first Signed-off-by: is from
> > Abhishek Sahu. But you have a From of Praveenkumar I ?
>
> I have no idea about this. This patch is from Qualcomm vendor linux code.
O.K. Since this is direct from the vendor, who probably does not track
code authorship correctly, i would say the author in git is probably
wrong. I would set the author: to Abhishek Sahu <absahu@...eaurora.org>.
> What's more, I don't known how to deal with these commit message since I'm
> not the author and I'm not sure do I have right to edit them even though
> this is GPL code.
You should keep all the Signed-off-by, in the order they are. But the
Change-Id is meaningless, so there is no problem removing them.
Andrew
Powered by blists - more mailing lists