[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240122205137.GH126470@kernel.org>
Date: Mon, 22 Jan 2024 20:51:37 +0000
From: Simon Horman <horms@...nel.org>
To: Suresh Kumar <suresh2514@...il.com>
Cc: jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, intel-wired-lan@...ts.osuosl.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH iwl v2] i40e: print correct hw max rss count in kernel
ring buffer
On Sat, Jan 20, 2024 at 12:58:06PM +0530, Suresh Kumar wrote:
> pf->rss_size_max is hardcoded and always prints max rss count as 64.
>
> Eg:
> kernel: i40e 0000:af:00.1: User requested queue count/HW max RSS count: 104/64
>
> whereas ethtool reports the correct value from "vsi->num_queue_pairs"
>
> Channel parameters for eno33:
> Pre-set maximums:
> RX: n/a
> TX: n/a
> Other: 1
> Combined: 104
> Current hardware settings:
> RX: n/a
> TX: n/a
> Other: 1
> Combined: 104 <-------
>
> and is misleading.
>
> Change it to vsi->num_queue_pairs
>
> Signed-off-by: Suresh Kumar <suresh2514@...il.com>
Hi Suresh,
following-up on our earlier emails.
I do think that if this it is a fix it should have a fixes tag.
Which should be for the commit where the bug was first visible to users.
Powered by blists - more mailing lists