netdev - Re: [PATCH v1 net] selftest: Don't reuse port for SO_INCOMING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240122131338.7c691d32@kernel.org>
Date: Mon, 22 Jan 2024 13:13:38 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Kuniyuki Iwashima
 <kuni1840@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 net] selftest: Don't reuse port for SO_INCOMING_CPU
 test.

On Fri, 19 Jan 2024 19:16:42 -0800 Kuniyuki Iwashima wrote:
> Jakub reported that ASSERT_EQ(cpu, i) in so_incoming_cpu.c seems to
> fire somewhat randomly.
> 
>   # #  RUN           so_incoming_cpu.before_reuseport.test3 ...
>   # # so_incoming_cpu.c:191:test3:Expected cpu (32) == i (0)
>   # # test3: Test terminated by assertion
>   # #          FAIL  so_incoming_cpu.before_reuseport.test3
>   # not ok 3 so_incoming_cpu.before_reuseport.test3
> 
> When the test failed, not-yet-accepted CLOSE_WAIT sockets received
> SYN with a "challenging" SEQ number, which was sent from an unexpected
> CPU that did not create the receiver.

Tested-by: Jakub Kicinski <kuba@...nel.org>

Thanks for a quick fix!