netdev - Re: [PATCH v6 iwl-next 3/7] ice: rename verify_cached to has_ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30427916-d123-b180-b64b-314d0e81cd63@intel.com>
Date: Mon, 22 Jan 2024 13:39:09 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Karol Kolacinski <karol.kolacinski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <jesse.brandeburg@...el.com>, Jacob Keller
	<jacob.e.keller@...el.com>
Subject: Re: [PATCH v6 iwl-next 3/7] ice: rename verify_cached to
 has_ready_bitmap

On 1/18/2024 9:45 AM, Karol Kolacinski wrote:
> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> The tx->verify_cached flag is used to inform the Tx timestamp tracking
> code whether it needs to verify the cached Tx timestamp value against
> a previous captured value. This is necessary on E810 hardware which does
> not have a Tx timestamp ready bitmap.
> 
> In addition, we currently rely on the fact that the
> ice_get_phy_tx_tstamp_ready() function returns all 1s for E810 hardware.
> Instead of introducing a brand new flag, rename and verify_cached to
> has_ready_bitmap,

Looks like you missed one...

drivers/net/ethernet/intel/ice/ice_ptp.c: In function 
‘ice_ptp_process_tx_tstamp’:
drivers/net/ethernet/intel/ice/ice_ptp.c:754:35: error: ‘struct 
ice_ptp_tx’ has no member named ‘verify_cached’
   754 |                 if (!drop_ts && tx->verify_cached &&

Thanks,
Tony

> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>