netdev - Re: [RFC PATCH v2 2/3] net: ti: icssg-switch: Add switchdev based driver for ethernet switch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9f770a9-5c49-44e2-ab81-c7eb35f0ed87@ti.com>
Date: Mon, 22 Jan 2024 13:24:18 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Simon Horman <horms@...nel.org>
CC: Rob Herring <robh@...nel.org>, Dan Carpenter <dan.carpenter@...aro.org>,
        Jan Kiszka <jan.kiszka@...mens.com>, Andrew Lunn <andrew@...n.ch>,
        "Vladimir
 Oltean" <vladimir.oltean@....com>,
        Wolfram Sang
	<wsa+renesas@...g-engineering.com>,
        Arnd Bergmann <arnd@...db.de>,
        "Grygorii
 Strashko" <grygorii.strashko@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Roger Quadros <rogerq@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        "Jakub
 Kicinski" <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S.
 Miller" <davem@...emloft.net>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <srk@...com>, <r-gunasekaran@...com>
Subject: Re: [RFC PATCH v2 2/3] net: ti: icssg-switch: Add switchdev based
 driver for ethernet switch support



On 20/01/24 2:10 am, Simon Horman wrote:
> On Thu, Jan 18, 2024 at 12:40:04PM +0530, MD Danish Anwar wrote:
> 
> ...
> 
>> @@ -211,6 +216,15 @@ struct prueth_pdata {
>>   * @iep0: pointer to IEP0 device
>>   * @iep1: pointer to IEP1 device
>>   * @vlan_tbl: VLAN-FID table pointer
>> + * @hw_bridge_dev: pointer to HW bridge net device
>> + * @br_members: bitmask of bridge member ports
>> + * @prueth_netdevice_nb: netdevice notifier block
>> + * @prueth_switchdevice_nb: switchdev notifier block
> 
> nit: s/prueth_switchdevice_nb/prueth_switchdev_nb/
> 
>      Flagged by ./scripts/kernel-doc -none>

Sure Simon. I will fix this.

>> + * @prueth_switchdev_bl_nb: switchdev blocking notifier block
>> + * @is_switch_mode: flag to indicate if device is in Switch mode
>> + * @is_switchmode_supported: indicates platform support for switch mode
>> + * @switch_id: ID for mapping switch ports to bridge
>> + * @default_vlan: Default VLAN for host
>>   */
>>  struct prueth {
>>  	struct device *dev;
>> @@ -236,6 +250,16 @@ struct prueth {
>>  	struct icss_iep *iep0;
>>  	struct icss_iep *iep1;
>>  	struct prueth_vlan_tbl *vlan_tbl;
>> +
>> +	struct net_device *hw_bridge_dev;
>> +	u8 br_members;
>> +	struct notifier_block prueth_netdevice_nb;
>> +	struct notifier_block prueth_switchdev_nb;
>> +	struct notifier_block prueth_switchdev_bl_nb;
>> +	bool is_switch_mode;
>> +	bool is_switchmode_supported;
>> +	unsigned char switch_id[MAX_PHYS_ITEM_ID_LEN];
>> +	int default_vlan;
>>  };
>>  
>>  struct emac_tx_ts_response {
> 
> ...

-- 
Thanks and Regards,
Danish