[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<DM6PR12MB45169D3312CEF3324B95B1CBD8742@DM6PR12MB4516.namprd12.prod.outlook.com>
Date: Tue, 23 Jan 2024 12:08:37 +0000
From: Danielle Ratson <danieller@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net"
<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
"pabeni@...hat.com" <pabeni@...hat.com>, "corbet@....net" <corbet@....net>,
"linux@...linux.org.uk" <linux@...linux.org.uk>, "sdf@...gle.com"
<sdf@...gle.com>, "kory.maincent@...tlin.com" <kory.maincent@...tlin.com>,
"maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>,
"vladimir.oltean@....com" <vladimir.oltean@....com>,
"przemyslaw.kitszel@...el.com" <przemyslaw.kitszel@...el.com>,
"ahmed.zaki@...el.com" <ahmed.zaki@...el.com>, "richardcochran@...il.com"
<richardcochran@...il.com>, "shayagr@...zon.com" <shayagr@...zon.com>,
"paul.greenwalt@...el.com" <paul.greenwalt@...el.com>, "jiri@...nulli.us"
<jiri@...nulli.us>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, mlxsw
<mlxsw@...dia.com>, Petr Machata <petrm@...dia.com>, Ido Schimmel
<idosch@...dia.com>
Subject: RE: [RFC PATCH net-next 8/9] ethtool: cmis_fw_update: add a layer for
supporting firmware update using CDB
> > +err_commit_image:
> > +err_run_image:
> > +err_download_image:
> > +err_fw_mng_features_get:
>
> name labels after the target
>
> > + ethtool_cmis_cdb_fini(cdb);
> > +err_cdb_init:
> > + ethnl_module_fw_flash_ntf_err(module_fw->dev, NULL);
> > +out:
> > + netdev_put(module_fw->dev, &module_fw->dev_tracker);
> > + module_fw->dev->module_fw_flash_in_progress = false;
> > + release_firmware(module_fw->fw);
> > + kfree(module_fw);
> > +}
> > +EXPORT_SYMBOL_GPL(ethtool_cmis_fw_update);
>
> does this really need to be exported?
It is actually can be dropped now, thanks.
Powered by blists - more mailing lists