[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5011cd73-10cb-42fc-8013-0695793580eb@web.de>
Date: Tue, 23 Jan 2024 16:25:11 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Phil Sutter <phil@....cc>, netfilter-devel@...r.kernel.org,
coreteam@...filter.org, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Florian Westphal <fw@...len.de>,
Jakub Kicinski <kuba@...nel.org>, Jozsef Kadlecsik <kadlec@...filter.org>,
Pablo Neira Ayuso <pablo@...filter.org>, Paolo Abeni <pabeni@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Kunwu Chan <chentao@...inos.cn>
Subject: Re: netfilter: nf_tables: Add a null pointer check in two functions
>> The result from a call of the function “kasprintf” was passed to
>> a subsequent function call without checking for a null pointer before
>> (according to a memory allocation failure).
>> This issue was detected by using the Coccinelle software.
>
> This is correct and I'm fine with the patch if it avoids ringing alarm
> bells somewhere, yet it doesn't fix an actual issue here since the
> allocated buffer is merely passed to vsnprintf() which detects and
> sanitizes %s args being NULL.
Should null pointer tolerance be better indicated for such use cases
by any additional means?
Regards,
Markus
Powered by blists - more mailing lists