[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240123-ripening-tabby-b97785375990@spud>
Date: Tue, 23 Jan 2024 16:06:31 +0000
From: Conor Dooley <conor@...nel.org>
To: Philippe Schenker <dev@...henker.ch>
Cc: netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
Conor Dooley <conor+dt@...nel.org>,
Woojung Huh <woojung.huh@...rochip.com>,
Vladimir Oltean <olteanv@...il.com>, linux-kernel@...r.kernel.org,
UNGLinuxDriver@...rochip.com, Marek Vasut <marex@...x.de>,
Florian Fainelli <f.fainelli@...il.com>, devicetree@...r.kernel.org,
Eric Dumazet <edumazet@...gle.com>,
"David S . Miller" <davem@...emloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Rob Herring <robh+dt@...nel.org>,
Philippe Schenker <philippe.schenker@...ulsing.ch>
Subject: Re: [PATCH net-next v1 1/2] dt-bindings: net: dsa: Add KSZ8567
switch support
On Tue, Jan 23, 2024 at 02:50:13PM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@...ulsing.ch>
>
> This commit adds the dt-binding for KSZ8567, a robust 7-port
> Ethernet switch. The KSZ8567 features two RGMII/MII/RMII interfaces,
> each capable of gigabit speeds, complemented by five 10/100 Mbps
> MAC/PHYs.
>
> Signed-off-by: Philippe Schenker <philippe.schenker@...ulsing.ch>
This device has all the same constraints as the other ones in this
binding, why is it not compatible with any of them? If it isn't, the
compatible should mention why it is not.
Cheers,
Conor.
> ---
>
> Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index c963dc09e8e1..52acc15ebcbf 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -31,6 +31,7 @@ properties:
> - microchip,ksz9893
> - microchip,ksz9563
> - microchip,ksz8563
> + - microchip,ksz8567
>
> reset-gpios:
> description:
> --
> 2.34.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists