netdev - Re: [PATCH net-next 1/3] tools: ynl: correct typo and docstring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m24jf4ypxl.fsf@gmail.com>
Date: Tue, 23 Jan 2024 16:28:38 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Alessandro Marcolini <alessandromarcolini99@...il.com>
Cc: davem@...emloft.net,  edumazet@...gle.com,  kuba@...nel.org,
  pabeni@...hat.com,  sdf@...gle.com,  chuck.lever@...cle.com,
  lorenzo@...nel.org,  jacob.e.keller@...el.com,  jiri@...nulli.us,
  netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] tools: ynl: correct typo and docstring

Alessandro Marcolini <alessandromarcolini99@...il.com> writes:

> Correct typo in SpecAttr docstring. Changed SpecSubMessageFormat
> docstring.

These docstring updates lgtm.

Reviewed-by: Donald Hunter <donald.hunter@...il.com>

> Signed-off-by: Alessandro Marcolini <alessandromarcolini99@...il.com>
> ---
>  tools/net/ynl/lib/nlspec.py | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/net/ynl/lib/nlspec.py b/tools/net/ynl/lib/nlspec.py
> index 44f13e383e8a..f8feae363970 100644
> --- a/tools/net/ynl/lib/nlspec.py
> +++ b/tools/net/ynl/lib/nlspec.py
> @@ -144,7 +144,7 @@ class SpecEnumSet(SpecElement):
>  
>  
>  class SpecAttr(SpecElement):
> -    """ Single Netlink atttribute type
> +    """ Single Netlink attribute type
>  
>      Represents a single attribute type within an attr space.
>  
> @@ -306,10 +306,9 @@ class SpecSubMessage(SpecElement):
>  
>  
>  class SpecSubMessageFormat(SpecElement):
> -    """ Netlink sub-message definition
> +    """ Netlink sub-message format definition
>  
> -    Represents a set of sub-message formats for polymorphic nlattrs
> -    that contain type-specific sub messages.
> +    Represents a single format for a sub-message.
>  
>      Attributes:
>          value         attribute value to match against type selector