netdev - Re: [PATCH net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2394.1706035034@famine>
Date: Tue, 23 Jan 2024 10:37:14 -0800
From: Jay Vosburgh <jay.vosburgh@...onical.com>
To: Hangbin Liu <liuhangbin@...il.com>
cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
    Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
    Eric Dumazet <edumazet@...gle.com>, Liang Li <liali@...hat.com>
Subject: Re: [PATCH net] selftests: bonding: do not test arp/ns target with mode balance-alb/tlb

Hangbin Liu <liuhangbin@...il.com> wrote:

>The prio_arp/ns tests hard code the mode to active-backup. At the same
>time, The balance-alb/tlb modes do not support arp/ns target. So remove
>the prio_arp/ns tests from the loop and only test active-backup mode.
>
>Fixes: 481b56e0391e ("selftests: bonding: re-format bond option tests")
>Reported-by: Jay Vosburgh <jay.vosburgh@...onical.com>
>Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/
>Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>


>---
> .../testing/selftests/drivers/net/bonding/bond_options.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/tools/testing/selftests/drivers/net/bonding/bond_options.sh b/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>index c54d1697f439..d508486cc0bd 100755
>--- a/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>+++ b/tools/testing/selftests/drivers/net/bonding/bond_options.sh
>@@ -162,7 +162,7 @@ prio_arp()
> 	local mode=$1
> 
> 	for primary_reselect in 0 1 2; do
>-		prio_test "mode active-backup arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
>+		prio_test "mode $mode arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect"
> 		log_test "prio" "$mode arp_ip_target primary_reselect $primary_reselect"
> 	done
> }
>@@ -178,7 +178,7 @@ prio_ns()
> 	fi
> 
> 	for primary_reselect in 0 1 2; do
>-		prio_test "mode active-backup arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
>+		prio_test "mode $mode arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect"
> 		log_test "prio" "$mode ns_ip6_target primary_reselect $primary_reselect"
> 	done
> }
>@@ -194,9 +194,9 @@ prio()
> 
> 	for mode in $modes; do
> 		prio_miimon $mode
>-		prio_arp $mode
>-		prio_ns $mode
> 	done
>+	prio_arp "active-backup"
>+	prio_ns "active-backup"
> }
> 
> arp_validate_test()
>-- 
>2.43.0
>