netdev - Re: [PATCH iproute2-next] m_mirred: Allow mirred to block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afb9ea78-9d9a-4ab3-bee4-a1da3175cdba@mojatatu.com>
Date: Tue, 23 Jan 2024 18:41:01 -0300
From: Victor Nogueira <victor@...atatu.com>
To: David Ahern <dsahern@...nel.org>, stephen@...workplumber.org,
 netdev@...r.kernel.org
Cc: kernel@...atatu.com
Subject: Re: [PATCH iproute2-next] m_mirred: Allow mirred to block

On 23/01/2024 15:17, David Ahern wrote:
> On 1/23/24 9:11 AM, Victor Nogueira wrote:
>> ---
>>   tc/m_mirred.c | 60 +++++++++++++++++++++++++++++++++++++++++----------
> 
> missing the man page update
> 
>> [...]
>> diff --git a/tc/m_mirred.c b/tc/m_mirred.c
>> index e5653e67f..db847b1a3 100644
>> --- a/tc/m_mirred.c
>> +++ b/tc/m_mirred.c
>> @@ -162,15 +167,38 @@ parse_direction(struct action_util *a, int *argc_p, char ***argv_p,
>>   					TCA_INGRESS_REDIR;
>>   				p.action = TC_ACT_STOLEN;
>>   				ok++;
>> -			} else if ((redir || mirror) &&
>> -				   matches(*argv, "dev") == 0) {
>> -				NEXT_ARG();
>> -				if (strlen(d))
>> -					duparg("dev", *argv);
>> -
>> -				strncpy(d, *argv, sizeof(d)-1);
>> -				argc--;
>> -				argv++;
>> +			} else if ((redir || mirror)) {
>> +				if (matches(*argv, "blockid") == 0) {
> 
> Not accepting any more uses of matches.
> [...]   

Thank you for the catches.
Sent a v2 fixing these issues.

cheers,
Victor