[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <db3afbe5-b6ea-425a-bf20-9a624aa959a6@intel.com>
Date: Tue, 23 Jan 2024 12:28:32 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Wojciech Drewek <wojciech.drewek@...el.com>,
<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <jiri@...nulli.us>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Remove and readd netdev
during devlink reload
On 1/23/24 12:18, Wojciech Drewek wrote:
> Recent changes to the devlink reload (commit 9b2348e2d6c9
> ("devlink: warn about existing entities during reload-reinit"))
> force the drivers to destroy devlink ports during reinit.
> Adjust ice driver to this requirement, unregister netdvice, destroy
> devlink port. ice_init_eth() was removed and all the common code
> between probe and reload was moved to ice_load().
>
> During devlink reload we can't take devl_lock (it's already taken)
> and in ice_probe() we have to lock it. Use devl_* variant of the API
> which does not acquire and release devl_lock. Guard ice_load()
> with devl_lock only in case of probe.
>
> Introduce ice_debugfs_fwlog_deinit() in order to release PF's
> debugfs entries. Move ice_debugfs_exit() call to ice_module_exit().
>
> Suggested-by: Jiri Pirko <jiri@...dia.com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---
> drivers/net/ethernet/intel/ice/ice.h | 3 +
> drivers/net/ethernet/intel/ice/ice_debugfs.c | 10 +
> drivers/net/ethernet/intel/ice/ice_devlink.c | 68 ++++++-
> drivers/net/ethernet/intel/ice/ice_fwlog.c | 2 +
> drivers/net/ethernet/intel/ice/ice_main.c | 189 ++++++-------------
> 5 files changed, 139 insertions(+), 133 deletions(-)
>
Thank you,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Powered by blists - more mailing lists