netdev - Re: [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170605983042.14933.14640605615298216416.git-patchwork-notify@kernel.org>
Date: Wed, 24 Jan 2024 01:30:30 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc: netdev@...r.kernel.org, gal@...dia.com, kuba@...nel.org,
 pabeni@...hat.com, edumazet@...gle.com, radu-nicolae.pirea@....nxp.com,
 davem@...emloft.net, sd@...asysnail.net
Subject: Re: [PATCH net v2 1/2] Revert "net: macsec: use
 skb_ensure_writable_head_tail to expand the skb"

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 18 Jan 2024 11:18:06 -0800 you wrote:
> This reverts commit b34ab3527b9622ca4910df24ff5beed5aa66c6b5.
> 
> Using skb_ensure_writable_head_tail without a call to skb_unshare causes
> the MACsec stack to operate on the original skb rather than a copy in the
> macsec_encrypt path. This causes the buffer to be exceeded in space, and
> leads to warnings generated by skb_put operations. Opting to revert this
> change since skb_copy_expand is more efficient than
> skb_ensure_writable_head_tail followed by a call to skb_unshare.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb"
    https://git.kernel.org/netdev/net/c/3222bc997a24
  - [net,v2,2/2] net: macsec: Only require headroom/tailroom from offload implementer if .mdo_insert_tx_tag is implemented
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html