netdev - Re: [PATCH v2] treewide, serdev: change receive_buf() return type to size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d4309e5-fdcd-13d7-2d4a-7139779e3fdd@linux.intel.com>
Date: Wed, 24 Jan 2024 13:38:18 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Francesco Dolcini <francesco@...cini.it>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    Jiri Slaby <jirislaby@...nel.org>, linux-bluetooth@...r.kernel.org, 
    linux-mediatek@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>, 
    linux-arm-kernel@...ts.infradead.org, greybus-dev@...ts.linaro.org, 
    linux-iio@...r.kernel.org, Netdev <netdev@...r.kernel.org>, 
    chrome-platform@...ts.linux.dev, platform-driver-x86@...r.kernel.org, 
    linux-serial <linux-serial@...r.kernel.org>, linux-sound@...r.kernel.org, 
    Francesco Dolcini <francesco.dolcini@...adex.com>, 
    Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
    Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>, 
    Jonathan Cameron <jic23@...nel.org>, Lee Jones <lee@...nel.org>, 
    Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
    Eric Dumazet <edumazet@...gle.com>, 
    "David S. Miller" <davem@...emloft.net>, 
    Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
    Hans de Goede <hdegoede@...hat.com>, Benson Leung <bleung@...omium.org>, 
    Tzung-Bi Shih <tzungbi@...nel.org>, Rob Herring <robh@...nel.org>, 
    Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2] treewide, serdev: change receive_buf() return type
 to size_t

On Mon, 22 Jan 2024, Francesco Dolcini wrote:

> From: Francesco Dolcini <francesco.dolcini@...adex.com>
> 
> receive_buf() is called from ttyport_receive_buf() that expects values
> ">= 0" from serdev_controller_receive_buf(), change its return type from
> ssize_t to size_t.
> 
> The need for this clean-up was noticed while fixing a warning, see
> commit 94d053942544 ("Bluetooth: btnxpuart: fix recv_buf() return value").
> Changing the callback prototype to return an unsigned seems the best way
> to document the API and ensure that is properly used.
> 
> GNSS drivers implementation of serdev receive_buf() callback return
> directly the return value of gnss_insert_raw(). gnss_insert_raw()
> returns a signed int, however this is not an issue since the value
> returned is always positive, because of the kfifo_in() implementation.
> gnss_insert_raw() could be changed to return also an unsigned, however
> this is not implemented here as request by the GNSS maintainer Johan
> Hovold.
> 
> Suggested-by: Jiri Slaby <jirislaby@...nel.org>
> Link: https://lore.kernel.org/all/087be419-ec6b-47ad-851a-5e1e3ea5cfcc@kernel.org/
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com> #for-iio

Acked-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.