[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <mdosj4utmgvuaezdceoyde2d2q44amozbpdvzo3clljqaxh5ap@x5i22jkftljg>
Date: Wed, 24 Jan 2024 14:19:10 +0100
From: Michal Koutný <mkoutny@...e.com>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
bpf@...r.kernel.org, cake@...ts.bufferbloat.net,
"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
Toke Høiland-Jørgensen <toke@...e.dk>, Vinicius Costa Gomes <vinicius.gomes@...el.com>,
Stephen Hemminger <stephen@...workplumber.org>, Petr Pavlu <ppavlu@...e.cz>, Michal Kubecek <mkubecek@...e.cz>,
Martin Wilck <mwilck@...e.com>, Pedro Tammela <pctammela@...atatu.com>
Subject: Re: [PATCH v4 0/4] net/sched: Load modules via alias
On Wed, Jan 24, 2024 at 07:17:27AM -0500, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> A small nit seeing Simon's comment which will have you respin.
> cls_tcindex is no longer in the kernel.
> Can you use another example?
I'd better do.
> Also Stephen had some comments last time, not sure if you addressed
> those (nothing on the logs says you did
It's these lines:
| Changes from v2 (https://lore.kernel.org/r/20231206192752.18989-1-mkoutny@suse.com)
| ...
| - used alias names more fitting the existing net- aliases
| - more info in commit messages and cover letter
> and i didnt see him say anything).
Me neither. I may amend the patches more if I missed anything.
Thanks,
Michal
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists