netdev - Re: [PATCH net-next 06/10] net: fill in MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240124174802.0b5910a5@xps-13>
Date: Wed, 24 Jan 2024 17:48:02 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Stefan Schmidt <stefan@...enfreihafen.org>
Cc: Breno Leitao <leitao@...ian.org>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, Alexander Aring
 <alex.aring@...il.com>, netdev@...r.kernel.org, "open list:IEEE 802.15.4
 SUBSYSTEM" <linux-wpan@...r.kernel.org>, open list
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for
 ieee802154

Hi,

stefan@...enfreihafen.org wrote on Tue, 9 Jan 2024 08:25:21 +0100:

> Hello.
> 
> On 08.01.24 19:16, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to ieee802154 modules.
> > 
> > Signed-off-by: Breno Leitao <leitao@...ian.org>
> > ---
> >   net/ieee802154/6lowpan/core.c | 1 +
> >   net/ieee802154/socket.c       | 1 +
> >   2 files changed, 2 insertions(+)
> > 
> > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> > index 2c087b7f17c5..b88f6a96d961 100644
> > --- a/net/ieee802154/6lowpan/core.c
> > +++ b/net/ieee802154/6lowpan/core.c
> > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void)  
> >   >   module_init(lowpan_init_module);  
> >   module_exit(lowpan_cleanup_module);
> > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core");  
> 
> If we want to nitpick you could write it as IEEE 802.15.4.

Also agreed, can you please post an update?

Thanks,
Miquèl