netdev - Re: [PATCH net-next v4 03/11] net: dsa: realtek: convert variants into real drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Jan 2024 11:19:00 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: netdev@...r.kernel.org, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
 andrew@...n.ch, f.fainelli@...il.com, olteanv@...il.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 arinc.unal@...nc9.com, ansuelsmth@...il.com
Subject: Re: [PATCH net-next v4 03/11] net: dsa: realtek: convert variants
 into real drivers

On Tue, 23 Jan 2024 18:55:55 -0300 Luiz Angelo Daros de Luca wrote:
> +/**
> + * realtek_mdio_remove() - Remove the driver of an MDIO-connected switch
> + * @pdev: platform_device to probe on.
> + *
> + * This function should be used as the .remove_new in an mdio_driver. First
> + * it unregisters the DSA switch and cleans internal data. If a method is
> + * provided, the hard reset is asserted to avoid traffic leakage.
> + *
> + * Context: Any context.
> + * Return: Nothing.
> + *
> + */
> +void realtek_mdio_remove(struct mdio_device *mdiodev)

kerne-doc says:

drivers/net/dsa/realtek/realtek-mdio.c:159: warning: Function parameter or struct member 'mdiodev' not described in 'realtek_mdio_probe'
drivers/net/dsa/realtek/realtek-mdio.c:159: warning: Excess function parameter 'pdev' description in 'realtek_mdio_probe'
drivers/net/dsa/realtek/realtek-mdio.c:268: warning: Function parameter or struct member 'mdiodev' not described in 'realtek_mdio_remove'
drivers/net/dsa/realtek/realtek-mdio.c:268: warning: Excess function parameter 'pdev' description in 'realtek_mdio_remove'
drivers/net/dsa/realtek/realtek-mdio.c:294: warning: Function parameter or struct member 'mdiodev' not described in 'realtek_mdio_shutdown'
drivers/net/dsa/realtek/realtek-mdio.c:294: warning: Excess function parameter 'pdev' description in 'realtek_mdio_shutdown'
-- 
pw-bot: cr