netdev - Re: [PATCH net] selftests: tcp_ao: set the timeout to 2 minutes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fc2ff95-35c6-4962-a299-3f520df7d4b3@gmail.com>
Date: Wed, 24 Jan 2024 23:51:52 +0000
From: Dmitry Safonov <0x7f454c46@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: tcp_ao: set the timeout to 2 minutes

On 1/24/24 23:36, Jakub Kicinski wrote:
> The default timeout for tests is 45sec, bench-lookups_ipv6
> seems to take around 50sec when running in a VM without
> HW acceleration. Give it a 2x margin and set the timeout
> to 120sec.
> 
> Fixes: d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks!
Reviewed-by: Dmitry Safonov <0x7f454c46@...il.com>

> ---
> Long story short I looked at the output for bench-lookups_ipv6
> and it seems to be a trivial timeout problem. With this we're at
> 22/24 passing for TCP AO, the reset case failures aren't as obvious...

I'll fix and send a patch for rst selftests on Thursday/Friday :)

> CC: shuah@...nel.org
> CC: 0x7f454c46@...il.com
> CC: linux-kselftest@...r.kernel.org
> ---
>  tools/testing/selftests/net/tcp_ao/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/net/tcp_ao/settings
> 
> diff --git a/tools/testing/selftests/net/tcp_ao/settings b/tools/testing/selftests/net/tcp_ao/settings
> new file mode 100644
> index 000000000000..6091b45d226b
> --- /dev/null
> +++ b/tools/testing/selftests/net/tcp_ao/settings
> @@ -0,0 +1 @@
> +timeout=120

Thanks,
             Dmitry