netdev - RE: [PATCH bpf-next 0/4] transition sockmap testing to test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Jan 2024 18:35:23 -0800
From: John Fastabend <john.fastabend@...il.com>
To: John Fastabend <john.fastabend@...il.com>, 
 netdev@...r.kernel.org, 
 jakub@...udflare.com
Cc: john.fastabend@...il.com, 
 bpf@...r.kernel.org
Subject: RE: [PATCH bpf-next 0/4] transition sockmap testing to test_progs

John Fastabend wrote:
> Its much easier to write and read tests than it was when sockmap was
> originally created. At that time we created a test_sockmap prog that
> did sockmap tests. But, its showing its age now. For example it reads
> user vars out of maps, is hard to run targetted tests, has a different
> format from the familiar test_progs and so on.
> 
> I recently thought there was an issue with pop helpers so I created
> some tests to try and track it down. It turns out it was a bug in the
> BPF program we had not the kernel. But, I think it makes sense to
> start deprecating test_sockmap and converting these to the nicer
> test_progs.
> 
> So this is a first round of test_prog tests for sockmap cork and
> pop helpers. I'll add push and pull tests shortly. I think its fine,
> maybe preferred to review smaller patchsets, to send these
> incrementally as I get them created.
> 
> Thanks!
> 
> John Fastabend (4):
>   bpf: Add modern test for sk_msg prog pop msg header
>   bpf: sockmap, add a sendmsg test so we can check that path
>   bpf: sockmap, add a cork to force buffering of the scatterlist
>   bpf: sockmap test cork and pop combined
> 
>  .../bpf/prog_tests/sockmap_helpers.h          |  18 +
>  .../bpf/prog_tests/sockmap_msg_helpers.c      | 351 ++++++++++++++++++
>  .../bpf/progs/test_sockmap_msg_helpers.c      |  67 ++++
>  3 files changed, 436 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/sockmap_msg_helpers.c
>  create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_msg_helpers.c
> 
> -- 
> 2.33.0
> 

Will need a v2 to fixup a couple things here. Thanks.