[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240125092909.exaisdjkkgmc5fue@skbuf>
Date: Thu, 25 Jan 2024 11:29:09 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Arınç ÜNAL <arinc.unal@...nc9.com>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
mithat.guner@...ont.com, erkin.bozoglu@...ont.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mt7530: select MEDIATEK_GE_PHY for
NET_DSA_MT7530_MDIO
On Mon, Jan 22, 2024 at 08:34:51AM +0300, Arınç ÜNAL wrote:
> Quoting from commit 4223f8651287 ("net: dsa: mt7530: make NET_DSA_MT7530
> select MEDIATEK_GE_PHY"):
>
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
>
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
>
> Now, the switch can be used without the PHYs but, at the moment, every
> hardware design out there that I have seen uses them. For that, it would
> make the most sense to force the selection of MEDIATEK_GE_PHY for the MDIO
> interface which currently controls the MT7530 and MT7531 switches.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
I see MEDIATEK_GE_PHY only depends on NETDEVICES && PHYLIB, so it should
have no problem being directly selected by a driver without breaking the
build by causing unmet dependencies.
I also see there is precedent with CONFIG_TXGBE selecting
MARVELL_10G_PHY, CONFIG_R8169 selecting REALTEK_PHY, and others.
Reviewed-by: Vladimir Oltean <olteanv@...il.com>
Powered by blists - more mailing lists