netdev - Re: [PATCH 3/3] net: stmmac: Time Based Scheduling support for OF platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734ulhber.fsf@geanix.com>
Date: Thu, 25 Jan 2024 12:58:52 +0100
From: esben@...nix.com
To: Kurt Kanzenbach <kurt.kanzenbach@...utronix.de>
Cc: netdev@...r.kernel.org,  Alexandre Torgue
 <alexandre.torgue@...s.st.com>,  Jose Abreu <joabreu@...opsys.com>,
  "David S. Miller" <davem@...emloft.net>,  Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo Abeni
 <pabeni@...hat.com>,  Maxime Coquelin <mcoquelin.stm32@...il.com>,
  linux-stm32@...md-mailman.stormreply.com,
  linux-arm-kernel@...ts.infradead.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] net: stmmac: Time Based Scheduling support for OF
 platforms

Kurt Kanzenbach <kurt.kanzenbach@...utronix.de> writes:

> Hi,
>
> On Wed Jan 24 2024, Esben Haabendal wrote:
>> This allows enabling TBS for TX queues by adding the
>> snps,time-based-scheduling property. You should check for support for this
>> on your particular controller before enabling. Typically, TX queue 0 does
>> not support TBS.
>
> More a general question: Do i see that correctly that Launch Time does
> not work for OF platforms (such as an imx93) at the moment, because the
> tbs_en property is not configured? Or why are these patches necessary?

Correct.  You cannot use etf qdisc with "offload" on for OF platforms,
including imx93.
Doing that will end with "return -EINVAL" in tc_setup_etf().

I am working with imx98mp, but there should not be any difference for
imx93.

/Esben