netdev - Re: [PATCH net] selftests: net: give more time for GRO aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLjpY=YZRBQdJdqOTvS_HKdSXeuaOA1OY2k5VujATz3iQ@mail.gmail.com>
Date: Thu, 25 Jan 2024 19:39:22 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: net: give more time for GRO aggregation

On Thu, Jan 25, 2024 at 7:09 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> The gro.sh test-case relay on the gro_flush_timeout to ensure
> that all the segments belonging to any given batch are properly
> aggregated.
>
> The other end, the sender is a user-space program transmitting
> each packet with a separate write syscall. A busy host and/or
> stracing the sender program can make the relevant segments reach
> the GRO engine after the flush timeout triggers.
>
> Give the GRO flush timeout more slack, to avoid sporadic self-tests
> failures.
>
> Fixes: 9af771d2ec04 ("selftests/net: allow GRO coalesce test on veth")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Tested-by: Eric Dumazet <edumazet@...gle.com>