netdev - RE: [PATCH net-next v3 2/2] net: txgbe: use irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 10:21:40 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Simon Horman'" <horms@...nel.org>
Cc: <davem@...emloft.net>,
	<edumazet@...gle.com>,
	<kuba@...nel.org>,
	<pabeni@...hat.com>,
	<linux@...linux.org.uk>,
	<andrew@...n.ch>,
	<netdev@...r.kernel.org>,
	<mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next v3 2/2] net: txgbe: use irq_domain for interrupt controller

On Wednesday, January 24, 2024 6:35 PM, Simon Horman wrote:
> On Wed, Jan 24, 2024 at 10:45:25AM +0800, Jiawen Wu wrote:
> 
> ...
> 
> > +static int txgbe_misc_irq_domain_map(struct irq_domain *d,
> > +				     unsigned int irq,
> > +				     irq_hw_number_t hwirq)
> > +{
> > +	struct txgbe *txgbe = d->host_data;
> > +
> > +	irq_set_chip_data(irq, txgbe);
> > +	irq_set_chip(irq, &txgbe->misc.chip);
> > +	irq_set_nested_thread(irq, TRUE);
> 
> Hi Jiawen Wu,
> 
> 'TRUE' seems undefined, causing a build failure.
> Should this be 'true' instead?

Oops. I built it with 'true' but sent the patch with 'TRUE'. ☹

> 
> > +	irq_set_noprobe(irq);
> > +
> > +	return 0;
> > +}
> 
> --
> pw-bot: changes-requested
>