netdev - Re: stmmac on Banana PI CPU stalls since Linux 6.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240126121028.2463aa68@meshulam.tesarici.cz>
Date: Fri, 26 Jan 2024 12:10:28 +0100
From: Petr Tesařík <petr@...arici.cz>
To: Marc Haber <mh+netdev@...schlus.de>
Cc: Florian Fainelli <f.fainelli@...il.com>, Andrew Lunn <andrew@...n.ch>,
 alexandre.torgue@...s.st.com, Jose Abreu <joabreu@...opsys.com>, Chen-Yu
 Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel
 Holland <samuel@...lland.org>, Jisheng Zhang <jszhang@...nel.org>,
 netdev@...r.kernel.org
Subject: Re: stmmac on Banana PI CPU stalls since Linux 6.6

On Fri, 26 Jan 2024 11:54:20 +0100
Marc Haber <mh+netdev@...schlus.de> wrote:

> On Fri, Jan 26, 2024 at 08:51:22AM +0100, Petr Tesařík wrote:
> > On Thu, 25 Jan 2024 12:00:46 -0800
> > Florian Fainelli <f.fainelli@...il.com> wrote:  
> > > Did not Petr try to address the same problem essentially:
> > > 
> > > https://lore.kernel.org/netdev/20240105091556.15516-1-petr@tesarici.cz/
> > > 
> > > this was not deemed the proper solution and I don't think one has been 
> > > posted since then, but it looks about your issue here Marc.  
> > 
> > Yes, it looks like the same issue I ran into on my NanoPi. I'm sorry
> > I've been busy with other things lately, so I could not test and submit
> > my changes.  
> 
> Is it worth trying your patch from the message cited above, knowing that
> is not the final solution?

Depends. It solves the deadlock (at least for me); my NanoPi has been
running stable for over a month with this patch. But it also introduces
a new spinlock, which usually reduces performance.

In any case, you can give it a try to verify that you hit the same
issue.

> > I hope I can find some time for this bug again during the coming weekend
> > (it's not for my day job). It's motivating to know that I'm not the
> > only affected person on the planet. ;-)  
> 
> I am ready to test if you want me to ;-)

Then you may want to start by verifying that it is indeed the same
issue. Try the linked patch.

Thank you!

Petr T