[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240126175107.GB401354@kernel.org>
Date: Fri, 26 Jan 2024 17:51:07 +0000
From: Simon Horman <horms@...nel.org>
To: Lukasz Plachno <lukasz.plachno@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
brett.creeley@....com, Jakub Buchocki <jakubx.buchocki@...el.com>,
Mateusz Pacuszka <mateuszx.pacuszka@...el.com>,
Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-next v4 2/2] ice: Implement 'flow-type ether' rules
On Wed, Jan 24, 2024 at 04:21:41PM +0100, Lukasz Plachno wrote:
> From: Jakub Buchocki <jakubx.buchocki@...el.com>
>
> Add support for 'flow-type ether' Flow Director rules via ethtool.
>
> Rules not containing masks are processed by the Flow Director,
> and support the following set of input parameters in all combinations:
> src, dst, proto, vlan-etype, vlan, action.
>
> It is possible to specify address mask in ethtool parameters but only
> 00:00:00:00:00 and FF:FF:FF:FF:FF are valid.
> The same applies to proto, vlan-etype and vlan masks:
> only 0x0000 and 0xffff masks are valid.
>
> Signed-off-by: Jakub Buchocki <jakubx.buchocki@...el.com>
> Co-developed-by: Mateusz Pacuszka <mateuszx.pacuszka@...el.com>
> Signed-off-by: Mateusz Pacuszka <mateuszx.pacuszka@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Lukasz Plachno <lukasz.plachno@...el.com>
...
> +/**
> + * ice_set_ether_flow_seg
nit: @dev should be documented here.
> + * @seg: flow segment for programming
> + * @eth_spec: mask data from ethtool
> + *
> + * Return: 0 on success and errno in case of error.
> + */
> +static int ice_set_ether_flow_seg(struct device *dev,
> + struct ice_flow_seg_info *seg,
> + struct ethhdr *eth_spec)
...
Powered by blists - more mailing lists