netdev - Re: [PATCH nf] netfilter: check SCTP_CID_SHUTDOWN_ACK for vtag setting in sctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240126000105.GC29056@breakpoint.cc>
Date: Fri, 26 Jan 2024 01:01:05 +0100
From: Florian Westphal <fw@...len.de>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org,
	linux-sctp@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	Florian Westphal <fw@...len.de>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH nf] netfilter: check SCTP_CID_SHUTDOWN_ACK for vtag
 setting in sctp_new

Xin Long <lucien.xin@...il.com> wrote:
> The annotation says in sctp_new(): "If it is a shutdown ack OOTB packet, we
> expect a return shutdown complete, otherwise an ABORT Sec 8.4 (5) and (8)".
> However, it does not check SCTP_CID_SHUTDOWN_ACK before setting vtag[REPLY]
> in the conntrack entry(ct).
> 
> Because of that, if the ct in Router disappears for some reason in [1]
> with the packet sequence like below:
 
Seems to be day 0 bug, so
Fixes: 9fb9cbb1082d ("[NETFILTER]: Add nf_conntrack subsystem.")