netdev - Re: [PATCH net-next v3 2/2] net: txgbe: use irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240126210445.GE401354@kernel.org>
Date: Fri, 26 Jan 2024 21:04:45 +0000
From: Simon Horman <horms@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux@...linux.org.uk, andrew@...n.ch,
	netdev@...r.kernel.org, mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v3 2/2] net: txgbe: use irq_domain for interrupt
 controller

On Thu, Jan 25, 2024 at 10:21:40AM +0800, Jiawen Wu wrote:
> On Wednesday, January 24, 2024 6:35 PM, Simon Horman wrote:
> > On Wed, Jan 24, 2024 at 10:45:25AM +0800, Jiawen Wu wrote:
> > 
> > ...
> > 
> > > +static int txgbe_misc_irq_domain_map(struct irq_domain *d,
> > > +				     unsigned int irq,
> > > +				     irq_hw_number_t hwirq)
> > > +{
> > > +	struct txgbe *txgbe = d->host_data;
> > > +
> > > +	irq_set_chip_data(irq, txgbe);
> > > +	irq_set_chip(irq, &txgbe->misc.chip);
> > > +	irq_set_nested_thread(irq, TRUE);
> > 
> > Hi Jiawen Wu,
> > 
> > 'TRUE' seems undefined, causing a build failure.
> > Should this be 'true' instead?
> 
> Oops. I built it with 'true' but sent the patch with 'TRUE'. ☹

It happens.

Please send a v2 with this fixed.
And please include Andrew's Reviewed-by tag unless
you make material changes to the patch.