[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZbNzfR5wzrKarP4h@gondor.apana.org.au>
Date: Fri, 26 Jan 2024 16:55:25 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Markus Elfring <Markus.Elfring@....de>
Cc: kernel test robot <lkp@...el.com>, virtualization@...ts.linux.dev,
linux-crypto@...r.kernel.org, kernel-janitors@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Gonglei <arei.gonglei@...wei.com>, Jason Wang <jasowang@...hat.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, llvm@...ts.linux.dev,
oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>, cocci@...ia.fr
Subject: Re: [PATCH v2] crypto: virtio - Less function calls in
__virtio_crypto_akcipher_do_req() after error detection
On Tue, Dec 26, 2023 at 11:12:23AM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 26 Dec 2023 11:00:20 +0100
>
> The kfree() function was called in up to two cases by the
> __virtio_crypto_akcipher_do_req() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
>
> * Adjust jump targets.
>
> * Delete two initialisations which became unnecessary
> with this refactoring.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>
> v2:
> A typo was fixed for the delimiter of a label.
>
> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists