netdev - Re: [PATCH net-next v6 00/13] Introduce PHY listing and link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240126172932.326f6b03@kernel.org>
Date: Fri, 26 Jan 2024 17:29:32 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com, Andrew Lunn
 <andrew@...n.ch>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>,
 linux-arm-kernel@...ts.infradead.org, Christophe Leroy
 <christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>,
 Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit
 <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>,
 Köry Maincent <kory.maincent@...tlin.com>, Jesse Brandeburg
 <jesse.brandeburg@...el.com>, Jonathan Corbet <corbet@....net>, Marek
 Behún <kabel@...nel.org>, Piergiorgio Beruto
 <piergiorgio.beruto@...il.com>, Oleksij Rempel <o.rempel@...gutronix.de>,
 Nicolò Veronese <nicveronese@...il.com>, Simon Horman
 <horms@...nel.org>
Subject: Re: [PATCH net-next v6 00/13] Introduce PHY listing and
 link_topology tracking

On Fri, 26 Jan 2024 19:38:37 +0100 Maxime Chevallier wrote:
> Most of the changes were from Jakub's and Russell's reviews, the main
> point being a rework of the netlink API, removing uneeded nests and
> cleaning-up the dump code. Thanks's Jakub for all the tips, hopefulle
> the API is cleaner now.

Didn't get a chance to look today, sorry, but it appears to break
allmodconfig build:

ld: net/core/dev.o: in function `free_netdev':
dev.c:(.text+0x76e1): undefined reference to `phy_link_topo_destroy'
ld: net/core/dev.o: in function `alloc_netdev_mqs':
dev.c:(.text+0x79c2): undefined reference to `phy_link_topo_create'

so maybe fix up and post v7?
-- 
pw-bot: cr