netdev - Re: [PATCH net-next v3 4/6] ethtool: add suffix _u32 to legacy bitmap members of struct ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8ef9ed4-196e-48f4-84fe-a23d46c99d5a@gmail.com>
Date: Sat, 27 Jan 2024 14:21:39 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 David Miller <davem@...emloft.net>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 4/6] ethtool: add suffix _u32 to legacy bitmap
 members of struct ethtool_keee

On 27.01.2024 06:20, Jakub Kicinski wrote:
> On Fri, 26 Jan 2024 23:15:33 +0100 Heiner Kallweit wrote:
>> This is in preparation of using the existing names for linkmode
>> bitmaps.
>>
>> Suggested-by: Andrew Lunn <andrew@...n.ch>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> missed some?
> 
Indeed, thanks.

> drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c:719:30: error: no member named 'supported' in 'struct ethtool_keee'
>   719 |                 eee->advertised_u32 = eee->supported;
>       |                                       ~~~  ^