netdev - Re: [PATCH net-next v4 2/6] ethtool: switch back from ethtool_keee to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf1fcc0d-d749-4474-a659-6ae11510ffd3@lunn.ch>
Date: Mon, 29 Jan 2024 00:57:38 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Russell King - ARM Linux <linux@...linux.org.uk>,
	Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v4 2/6] ethtool: switch back from ethtool_keee
 to ethtool_eee for ioctl

On Sat, Jan 27, 2024 at 02:26:06PM +0100, Heiner Kallweit wrote:
> In order to later extend struct ethtool_keee, we have to decouple it
> from the userspace format represented by struct ethtool_eee.
> Therefore switch back to struct ethtool_eee, representing the userspace
> format, and add conversion between ethtool_eee and ethtool_keee.
> Struct ethtool_keee will be changed in follow-up patches, therefore
> don't do a *keee = *eee here.
> Member cmd isn't copied, because it's not used, and we'll remove
> it in the next patch of this series. In addition omit setting cmd
> to ETHTOOL_GEEE in the ioctl response, userspace ethtool isn't
> interested in it.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew