netdev - Re: [PATCH net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbZiJU49cDWId4s5@shredder>
Date: Sun, 28 Jan 2024 16:18:13 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Petr Machata <petrm@...dia.com>, David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	vadimp@...dia.com
Subject: Re: [PATCH net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o
 detect and address_list

On Sat, Jan 27, 2024 at 04:08:18PM +0100, Heiner Kallweit wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>

> ---
>  drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> index 6b98c3287..f0ceb196a 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> @@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = {
>  
>  static struct i2c_driver mlxsw_m_i2c_driver = {
>  	.driver.name = "mlxsw_minimal",
> -	.class = I2C_CLASS_HWMON,
>  	.id_table = mlxsw_m_i2c_id,
>  };
>  
> -- 
> 2.43.0
>