netdev - Re: [PATCH next 10/11] block: Use a boolean expression instead of max() on booleans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whxYjLFhjov39N67ePb3qmCmxrhbVXEtydeadfao53P+A@mail.gmail.com>
Date: Sun, 28 Jan 2024 11:59:29 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: David Laight <David.Laight@...lab.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Netdev <netdev@...r.kernel.org>, 
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, "Matthew Wilcox (Oracle)" <willy@...radead.org>, 
	Christoph Hellwig <hch@...radead.org>, Dan Carpenter <dan.carpenter@...aro.org>, 
	Linus Walleij <linus.walleij@...aro.org>, "David S . Miller" <davem@...emloft.net>, 
	"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH next 10/11] block: Use a boolean expression instead of
 max() on booleans

On Sun, 28 Jan 2024 at 11:36, David Laight <David.Laight@...lab.com> wrote:
>
> However it generates:
> error: comparison of constant â€˜0â€™ with boolean expression is always true [-Werror=bool-compare]
> inside the signedness check that max() does unless a '+ 0' is added.

Please fix your locale. You have random garbage characters there,
presumably because you have some incorrect locale setting somewhere in
your toolchain.

           Linus