netdev - Re: [net-next 04/15] net/mlx5: SD, Implement basic query and instantiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZbduEnFa8ULWxDt_@nanopsycho>
Date: Mon, 29 Jan 2024 10:21:22 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: Saeed Mahameed <saeed@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
	Tariq Toukan <tariqt@...dia.com>
Subject: Re: [net-next 04/15] net/mlx5: SD, Implement basic query and
 instantiation

Thu, Jan 25, 2024 at 08:34:25AM CET, ttoukan.linux@...il.com wrote:
>
>
>On 05/01/2024 14:15, Jiri Pirko wrote:
>> Thu, Dec 21, 2023 at 01:57:10AM CET, saeed@...nel.org wrote:
>> > From: Tariq Toukan <tariqt@...dia.com>
>> 
>> [...]
>> 
>> > +static int sd_init(struct mlx5_core_dev *dev)
>> 
>> Could you maintain "mlx5_" prefix here and in the rest of the patches?
>> 
>> 
>
>Hi Jiri,
>
>We do not necessarily maintain this prefix for non-exposed static functions.

Yet, it is very common all over mlx5 driver. It is much more common than
no prefix. Why this is exception?


>
>> > +{
>> 
>> [...]