netdev - Re: [net-next PATCH 0/3] net: mdio-ipq4019: fix wrong default MDC rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df0e0ddc-4134-41d0-94f4-aba1186f0ede@lunn.ch>
Date: Mon, 29 Jan 2024 16:29:11 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Jie Luo <quic_luoj@...cinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Andy Gross <agross@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Robert Marko <robert.marko@...tura.hr>,
	linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sergey Ryazanov <ryazanov.s.a@...il.com>
Subject: Re: [net-next PATCH 0/3] net: mdio-ipq4019: fix wrong default MDC
 rate

On Mon, Jan 29, 2024 at 03:25:09PM +0100, Christian Marangi wrote:
> On Mon, Jan 29, 2024 at 09:59:03PM +0800, Jie Luo wrote:
> > 
> > 
> > On 1/27/2024 1:33 AM, Christian Marangi wrote:
> > > On Fri, Jan 26, 2024 at 07:20:03PM +0200, Dmitry Baryshkov wrote:
> > > > On Fri, 26 Jan 2024 at 18:03, Jie Luo <quic_luoj@...cinc.com> wrote:
> > > > > 
> > > > > 
> > > > > 
> > > > > On 1/26/2024 1:18 AM, Andrew Lunn wrote:
> > > > > > > Hi Christian,
> > > > > > > Just a gentle reminder.
> > > > > > > 
> > > > > > > The MDIO frequency config is already added by the following patch series.
> > > > > > > https://lore.kernel.org/netdev/28c8b31c-8dcb-4a19-9084-22c77a74b9a1@linaro.org/T/#m840cb8d269dca133c3ad3da3d112c63382ec2058
> > > > > > 
> > > > > > I admit this version was posted first. However, its embedded in a
> > > > > > patch series which is not making much progress, and i doubt will make
> > > > > > progress any time soon.
> > > > > > 
> > > > > > If you really want your version to be used, please split it out into a
> > > > > > standalone patch series adding just MDIO clock-frequency support, with
> > > > > > its binding, and nothing else.
> > > > > > 
> > > > > >       Andrew
> > > > > 
> > > > > Hi Andrew,
> > > > > We will rework the patch series to include only MDIO frequency related
> > > > > function and frequency dt binding, and post the updated patch series
> > > > > on th/Tuesdae Mondayy of next week. We will work with Christian to
> > > > > ensure he can re-use this patch as well.
> > > > 
> > > > Can you do the other way around: rebase your patches on top of Chritian's work?
> > 
> > Hi Dmitry,
> > Sure, we can take this approach if fine by Andrew as well.
> > 
> > > > 
> > > 
> > > Would be ideal, also I have to send v2 that handle the 802.3 suggested
> > > MDC rate (ready I just need to send after this has been handled).
> > > 
> > > Also I can see some problem with Lui patch where thse divior
> > > value is not reapplied after MDIO reset effectively reverting to the
> > > default value.
> > 
> > Hi Christian,
> > In my version, the divisor is programmed in every MDIO operation and hence I
> > did not add the code to revert to configured value in reset function. But
> > sure. we can program it once during the probe/reset and avoid doing it
> > during read/write ops.
> > 
> > In addition, the MDIO divisor 1, 2 and 4 are not supported by the MDIO
> > hardware block, maybe we can remove these macros to avoid confusion, or add
> > a comment mentioning that these are not supported.
> >
> 
> Hi, thanks for confirming it! In v2 I already changed the logic to start
> looping from divisor 8 and added comments in DT and driver about not
> assuring correct funcionality with those divisor.

Hi Christian

Lets go with your version. Please post V2 whenever you are ready.

Jie, please spend some time reviewing to patches, make any comments
you have, and if everything is O.K, you can add a Reviewed-by:

    Andrew