netdev - Re: [PATCH net-next v4 03/11] net: dsa: realtek: convert variants into real drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240129162156.wrahfl4rdev45ro5@skbuf>
Date: Mon, 29 Jan 2024 18:21:56 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: netdev@...r.kernel.org, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
	andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	arinc.unal@...nc9.com, ansuelsmth@...il.com
Subject: Re: [PATCH net-next v4 03/11] net: dsa: realtek: convert variants
 into real drivers

On Sun, Jan 28, 2024 at 08:34:29PM -0300, Luiz Angelo Daros de Luca wrote:
> > > + * This function should be used as the .shutdown in an mdio_driver. It shuts
> > > + * down the DSA switch and cleans the platform driver data.
> >
> > , to prevent realtek_mdio_remove() from running afterwards, which is
> > possible if the parent bus implements its own .shutdown() as .remove().
> 
> I didn't think that both could be called in sequence. I learned
> something today. Thanks.

And neither did I, until it happened to a user... More details in commit
0650bf52b31f ("net: dsa: be compatible with masters which unregister on
shutdown") after "However, complications arise really quickly".