[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2c37a716-e4bb-4db3-a95f-a40e05b28cad@molgen.mpg.de>
Date: Mon, 29 Jan 2024 17:31:52 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Chen-Yu Tsai <wenst@...omium.org>
Cc: Marcel Holtmann <marcel@...tmann.org>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
<matthias.bgg@...il.com>,
Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Sean Wang <sean.wang@...iatek.com>, linux-bluetooth@...r.kernel.org,
netdev@...r.kernel.org, linux-mediatek@...ts.infradead.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: mediatek: mt8183-pico6: Fix bluetooth
node
Dear Chen-Yu,
Thank you for your patch.
Am 26.01.24 um 07:34 schrieb Chen-Yu Tsai:
> Bluetooth is not a random device connected to the MMC/SD controller. It
> is function 2 of the SDIO device.
>
> Fix the address of the bluetooth node. Also fix the node name and drop
> the label.
Excuse my ignorance: Is this a cosmetic fix or does it fix the device
somehow?
> Fixes: 055ef10ccdd4 ("arm64: dts: mt8183: Add jacuzzi pico/pico6 board")
> Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
> Changes since v1:
> - Collected reviewed-by
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
> index a2e74b829320..6a7ae616512d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
> @@ -82,7 +82,8 @@ pins-clk {
> };
>
> &mmc1 {
> - bt_reset: bt-reset {
> + bluetooth@2 {
> + reg = <2>;
To avoid confusion, would it be possible to use sdio as a “name”.
> compatible = "mediatek,mt7921s-bluetooth";
> pinctrl-names = "default";
> pinctrl-0 = <&bt_pins_reset>;
Kind regards,
Paul
Powered by blists - more mailing lists