netdev - Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbjKDLtbiKXYpKew@nanopsycho>
Date: Tue, 30 Jan 2024 11:06:04 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Kunwu Chan <chentao@...inos.cn>
Cc: roopa@...dia.com, razor@...ckwall.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	bridge@...ts.linux.dev, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of
 kmem_cache_create

Tue, Jan 30, 2024 at 10:25:36AM CET, chentao@...inos.cn wrote:
>commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>introduces a new macro.
>Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>to simplify the creation of SLAB caches.
>
>Signed-off-by: Kunwu Chan <chentao@...inos.cn>
>---
> net/bridge/br_fdb.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
>index c622de5eccd0..c77591e63841 100644
>--- a/net/bridge/br_fdb.c
>+++ b/net/bridge/br_fdb.c
>@@ -35,10 +35,7 @@ static struct kmem_cache *br_fdb_cache __read_mostly;
> 
> int __init br_fdb_init(void)
> {
>-	br_fdb_cache = kmem_cache_create("bridge_fdb_cache",
>-					 sizeof(struct net_bridge_fdb_entry),
>-					 0,
>-					 SLAB_HWCACHE_ALIGN, NULL);
>+	br_fdb_cache = KMEM_CACHE(net_bridge_fdb_entry, SLAB_HWCACHE_ALIGN);

Same remark as to the previous patch, the name would change.



> 	if (!br_fdb_cache)
> 		return -ENOMEM;
> 
>-- 
>2.39.2
>
>