[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <efd5126fcfe840d9bb7d583c8c69a3c97cdb2285.camel@redhat.com>
Date: Tue, 30 Jan 2024 12:40:59 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Furong Xu <0x1207@...il.com>, "David S. Miller" <davem@...emloft.net>,
Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
<joabreu@...opsys.com>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Joao Pinto
<jpinto@...opsys.com>, Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
xfr@...look.com, rock.xu@....com
Subject: Re: [PATCH net v2] net: stmmac: xgmac: fix handling of DPP safety
error for DMA channels
On Fri, 2024-01-26 at 15:39 +0800, Furong Xu wrote:
> @@ -914,7 +964,12 @@ static int dwxgmac3_safety_feat_irq_status(struct net_device *ndev,
> ret |= !corr;
> }
>
> - err = dma & (XGMAC_DEUIS | XGMAC_DECIS);
> + /* DMA_DPP_Interrupt_Status is indicated by MCSIS bit in
> + * DMA_Safety_Interrupt_Status, so we handle DMA Data Path
> + * Parity Errors here
> + */
> + err = (dma & (XGMAC_DEUIS | XGMAC_DECIS)) ||
> + (dma & XGMAC_MCSIS);
The above syntax is IMHO confusing,
err = (dma & (XGMAC_DEUIS | XGMAC_DECIS | XGMAC_MCSIS))
should be more readable.
Cheers,
Paolo
Powered by blists - more mailing lists